]> git.proxmox.com Git - mirror_qemu.git/commit
python/machine: close sock_pair in cleanup path
authorJohn Snow <jsnow@redhat.com>
Thu, 28 Sep 2023 04:49:39 +0000 (00:49 -0400)
committerJohn Snow <jsnow@redhat.com>
Wed, 11 Oct 2023 20:02:02 +0000 (16:02 -0400)
commit612b3ba218092825467810b1a38de2026dac2bfc
tree9c87b952eb356c744940d6f10c06ccbe94bcfc35
parent91e11db7bcc486db2dc2bdab94ac5de62c02ce9a
python/machine: close sock_pair in cleanup path

If everything has gone smoothly, we'll already have closed the socket we
gave to the child during post_launch. The other half of the pair that we
gave to the QMP connection should, likewise, be definitively closed by
now.

However, in the cleanup path, it's possible we've created the socketpair
but flubbed the launch and need to clean up resources. These resources
*would* be handled by the garbage collector, but that can happen at
unpredictable times. Nicer to just clean them up synchronously on the
exit path, here.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20230928044943.849073-3-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
python/qemu/machine/machine.py