]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
drm/i915/cnl: Fix PLL initialization for HDMI.
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 3 Oct 2017 22:08:59 +0000 (15:08 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 16 Oct 2017 23:50:05 +0000 (16:50 -0700)
commit614ee07acfbb55f2debfc3223ffae97fee17ed14
tree280def64f6ef4e9848b7900e4919f9432b053a01
parent87145d95c3d8297fb74762bd92e022d7f5cc250c
drm/i915/cnl: Fix PLL initialization for HDMI.

HDMI Mode selection on CNL is on CFGCR0 for that PLL, not
on in a global CTRL1 as it was on SKL.

The original patch addressed this difference, but leaving behind
this single entry here. So we were checking the wrong bits during
the PLL initialization and consequently avoiding the CFGCR1 setup
during HDMI initialization. Luckly when only HDMI was in use BIOS
had already setup this for us. But the dual display with hot plug
were messed up.

Fixes: a927c927de34 ("drm/i915/cnl: Initialize PLLs")
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Kahola, Mika <mika.kahola@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: James Ausmus <james.ausmus@intel.com>
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171003220859.21352-3-rodrigo.vivi@intel.com
drivers/gpu/drm/i915/intel_dpll_mgr.c