]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
mmc: omap_hsmmc: remove prepare/complete system suspend support.
authorNeilBrown <neilb@suse.de>
Thu, 11 Dec 2014 21:43:08 +0000 (08:43 +1100)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 19 Jan 2015 08:56:08 +0000 (09:56 +0100)
commit61bd8a04b379e4fefbc0b0d06941d3f91071bb8c
tree13f5cd3129aa21dfa7ff266e69801f981335910b
parent8a66fdae771487762519db0546e9ccb648a2f911
mmc: omap_hsmmc: remove prepare/complete system suspend support.

The only function of these 'prepare' and 'complete' is to
disable the 'card detect' irq during suspend.

The commit which added this,
commit a48ce884d5819d5df2cf1139ab3c43f8e9e419b3
    mmc: omap_hsmmc: Introduce omap_hsmmc_prepare/complete

justified it by the need to avoid the registration of new devices
during suspend.
However mmc_pm_notify will set ->rescan_disable in the 'prepare'
stage and clear it in the 'complete' stage, so no card detection
will actually happen.
Also the interrupt will be disabled before final suspend as part
of common suspend processing.

So this disabling of the interrupt is unnecessary, and interferes
with a transition to using common code for card-detect management.

Cc: Felipe Balbi <balbi@ti.com>
Cc: Venkatraman S <svenkatr@ti.com>
Cc: Chris Ball <cjb@laptop.org>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/omap_hsmmc.c
include/linux/platform_data/mmc-omap.h