]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
iwlwifi: mvm: fix a NULL pointer dereference of error in recovery
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Mon, 12 Jun 2017 12:10:09 +0000 (15:10 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 21 Jul 2017 09:26:37 +0000 (12:26 +0300)
commit61dd8a8a6a0c3cbfb6b02ab652c4f4efb93f3d79
tree8c7d54f6a8661d448dbb9e6983a633f58b14afe7
parentf6eac740a9b6f3737a969bad82931633519a1cc5
iwlwifi: mvm: fix a NULL pointer dereference of error in recovery

Sometimes, we can have an firmware crash while trying to
recover from a previous firmware problem.
When that happens, lots of things can go wrong. For example
the stations don't get added properly to mvm->fw_id_to_mac_id.

Mac80211 tries to stop A-MPDU upon reconfig but in case of
a firmware crash we will bail out fairly early and in the
end, we won't delete the A-MPDU Rx timeout.
When that timer expired after a double firmware crash,
we end up dereferencing mvm->fw_id_to_mac_id[sta_id]
which is NULL.

Fixes: 10b2b2019d81 ("iwlwifi: mvm: add infrastructure for tracking BA session in driver")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/sta.c