]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
flow_dissector: do not dissect l4 ports for fragments
author배석진 <soukjin.bae@samsung.com>
Sat, 10 Nov 2018 00:53:06 +0000 (16:53 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 10 Nov 2018 04:01:21 +0000 (20:01 -0800)
commit62230715fd2453b3ba948c9d83cfb3ada9169169
tree661b09b8456959419d4be214b59a2772804ec7e0
parentd02854dc1999ed3e7fd79ec700c64ac23ac0c458
flow_dissector: do not dissect l4 ports for fragments

Only first fragment has the sport/dport information,
not the following ones.

If we want consistent hash for all fragments, we need to
ignore ports even for first fragment.

This bug is visible for IPv6 traffic, if incoming fragments
do not have a flow label, since skb_get_hash() will give
different results for first fragment and following ones.

It is also visible if any routing rule wants dissection
and sport or dport.

See commit 5e5d6fed3741 ("ipv6: route: dissect flow
in input path if fib rules need it") for details.

[edumazet] rewrote the changelog completely.

Fixes: 06635a35d13d ("flow_dissect: use programable dissector in skb_flow_dissect and friends")
Signed-off-by: 배석진 <soukjin.bae@samsung.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/flow_dissector.c