]> git.proxmox.com Git - mirror_qemu.git/commit
monitor: allow device_del to accept QOM paths
authorDaniel P. Berrange <berrange@redhat.com>
Fri, 11 Sep 2015 12:33:56 +0000 (13:33 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 22 Sep 2015 09:31:56 +0000 (11:31 +0200)
commit6287d827d494b5850049584c3f7fb1a589dbb1de
tree30f2e39cf5ca440c911434aa9c2c587e1f625f6c
parent9e72681d16792d0ffc42bab634b1753ff299bdfd
monitor: allow device_del to accept QOM paths

Currently device_del requires that the client provide the
device short ID. device_add allows devices to be created
without giving an ID, at which point there is no way to
delete them with device_del. The QOM object path, however,
provides an alternative way to identify the devices.

Allowing device_del to accept an object path ensures all
devices are deletable regardless of whether they have an
ID.

 (qemu) device_add usb-mouse
 (qemu) qom-list /machine/peripheral-anon
 device[0] (child<usb-mouse>)
 type (string)
 (qemu) device_del /machine/peripheral-anon/device[0]

Devices are required to be marked as hotpluggable
otherwise an error is raised

 (qemu) device_del /machine/unattached/device[4]
 Device 'PIIX3' does not support hotplugging

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1441974836-17476-1-git-send-email-berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[Commit message touched up, accidental white-space change dropped]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
hmp-commands.hx
qapi-schema.json
qdev-monitor.c
qmp-commands.hx