]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
usb: xhci: Fix port minor revision
authorThinh Nguyen <Thinh.Nguyen@synopsys.com>
Thu, 11 Mar 2021 03:43:21 +0000 (19:43 -0800)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 19 May 2021 08:31:59 +0000 (10:31 +0200)
commit628a55ff20985b7a9a1bac13a306bc84f8574921
tree66c1ac57bb8720e9c90548d77626ddace659a4e4
parenta2e9acc58dafd87520da6e58f38f48f54eeed1f4
usb: xhci: Fix port minor revision

BugLink: https://bugs.launchpad.net/bugs/1928857
[ Upstream commit 64364bc912c01b33bba6c22e3ccb849bfca96398 ]

Some hosts incorrectly use sub-minor version for minor version (i.e.
0x02 instead of 0x20 for bcdUSB 0x320 and 0x01 for bcdUSB 0x310).
Currently the xHCI driver works around this by just checking for minor
revision > 0x01 for USB 3.1 everywhere. With the addition of USB 3.2,
checking this gets a bit cumbersome. Since there is no USB release with
bcdUSB 0x301 to 0x309, we can assume that sub-minor version 01 to 09 is
incorrect. Let's try to fix this and use the minor revision that matches
with the USB/xHCI spec to help with the version checking within the
driver.

Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/ed330e95a19dc367819c5b4d78bf7a541c35aa0a.1615432770.git.Thinh.Nguyen@synopsys.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/usb/host/xhci-mem.c