]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
[media] davinci: vpif_capture: fix start/stop streaming locking
authorKevin Hilman <khilman@baylibre.com>
Wed, 7 Dec 2016 18:30:23 +0000 (16:30 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 31 Jan 2017 10:01:07 +0000 (08:01 -0200)
commit62dd4acd0bc8640ff2804bf8fda5baace266e95f
treef4253db20c580af79d1596b8ec564bbb025890f9
parent2d40cb3f0d710bb4c656f9b2f021c964f501baea
[media] davinci: vpif_capture: fix start/stop streaming locking

Video capture subdevs may be over I2C and may sleep during xfer, so we
cannot do IRQ-disabled locking when calling the subdev.

The IRQ-disabled locking is meant to protect the DMA queue list
throughout the rest of the driver, so update the locking in
[start|stop]_streaming to protect just this list, and update the irqlock
comment to reflect what it actually protects.

Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/davinci/vpif_capture.c
drivers/media/platform/davinci/vpif_capture.h