]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
pwm: rockchip: Don't modify HW state in .remove() callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 7 Jul 2021 16:27:52 +0000 (18:27 +0200)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Wed, 27 Oct 2021 23:04:23 +0000 (17:04 -0600)
commit63c9db6368c0d1e1f7942cb73d5c224a318537c5
treef6093aa71d26cc4c206b3e89797a49dab72e97ae
parent877a606a20d33f4388f727ba6e08d09dcce5b9c3
pwm: rockchip: Don't modify HW state in .remove() callback

BugLink: https://bugs.launchpad.net/bugs/1947885
[ Upstream commit 9d768cd7fd42bb0be16f36aec48548fca5260759 ]

A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/pwm/pwm-rockchip.c