]> git.proxmox.com Git - mirror_qemu.git/commit
chardev: give some context on chardev-add error
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Wed, 28 Jul 2021 11:34:43 +0000 (15:34 +0400)
committerMarc-André Lureau <marcandre.lureau@redhat.com>
Thu, 5 Aug 2021 12:15:33 +0000 (16:15 +0400)
commit64195b0d365712c05ae922b7ff22cf136aac1400
tree10be11affd1eecbd41fb3f9e0104a39a39e8aa8c
parent733ba020846ccd21d832f2e9b62387a86c5ab8f1
chardev: give some context on chardev-add error

Description from Daniel P. Berrangé:
> The original code reported:
>
>  "attempt to add duplicate property 'char2' to object (type 'container')"
>
> Since adding yank support, the current code reports
>
>  "duplicate yank instance"
>
> With this patch applied it now reports:
>
>  "Failed to add chardev 'char2': duplicate yank instance"
>
> This is marginally better, but still not great, not that the original
> error was great either.
>
> It would be nice if we could report
>
>   "chardev with id 'char2' already exists"

Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1984721

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
chardev/char.c