]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
media: pci: ttpci: av7110: fix possible buffer overflow caused by bad DMA value in...
authorJia-Ju Bai <baijiaju@tsinghua.edu.cn>
Sat, 30 May 2020 14:42:08 +0000 (16:42 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 23 Jun 2020 13:09:43 +0000 (15:09 +0200)
commit6499a0db9b0f1e903d52f8244eacc1d4be00eea2
treee5c4c00e9129804e6cedd597c1792998926283d2
parentbc76369b89bbbbd01b2a3852287ea8092b59d012
media: pci: ttpci: av7110: fix possible buffer overflow caused by bad DMA value in debiirq()

The value av7110->debi_virt is stored in DMA memory, and it is assigned
to data, and thus data[0] can be modified at any time by malicious
hardware. In this case, "if (data[0] < 2)" can be passed, but then
data[0] can be changed into a large number, which may cause buffer
overflow when the code "av7110->ci_slot[data[0]]" is used.

To fix this possible bug, data[0] is assigned to a local variable, which
replaces the use of data[0].

Signed-off-by: Jia-Ju Bai <baijiaju@tsinghua.edu.cn>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/pci/ttpci/av7110.c