]> git.proxmox.com Git - mirror_qemu.git/commit
hw: Replace trivial drive_get_next() by drive_get()
authorMarkus Armbruster <armbru@redhat.com>
Wed, 17 Nov 2021 16:33:58 +0000 (17:33 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 15 Dec 2021 07:38:16 +0000 (08:38 +0100)
commit64eaa8209597a580c026d4891c072723a38ff0a6
tree73af3e7e719b27d6462df231ae8bc05ac1238635
parent36aa285f48d55451bb2eb7a2c0f9635a3c2bbe46
hw: Replace trivial drive_get_next() by drive_get()

drive_get_next() is basically a bad idea.  It returns the "next" block
backend of a certain interface type.  "Next" means bus=0,unit=N, where
subsequent calls count N up from zero, per interface type.

This lets you define unit numbers implicitly by execution order.  If the
order changes, or new calls appear "in the middle", unit numbers change.
ABI break.  Hard to spot in review.

A number of machines connect just one backend with drive_get_next().
Change them to use drive_get() directly.  This makes the (zero) unit
number explicit in the code.

Cc: Beniamino Galvani <b.galvani@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Subbaraya Sundeep <sundeep.lkml@gmail.com>
Cc: Niek Linnenbank <nieklinnenbank@gmail.com>
Cc: Andrew Baumann <Andrew.Baumann@microsoft.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Jean-Christophe Dubois <jcd@tribudubois.net>
Cc: Alistair Francis <Alistair.Francis@wdc.com>
Cc: Bin Meng <bin.meng@windriver.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Artyom Tarasenko <atar4qemu@gmail.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Michael Tokarev <mjt@tls.msk.ru>
Cc: Laurent Vivier <laurent@vivier.eu>
Cc: qemu-arm@nongnu.org
Cc: qemu-riscv@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20211117163409.3587705-3-armbru@redhat.com>
hw/arm/cubieboard.c
hw/arm/integratorcp.c
hw/arm/msf2-som.c
hw/arm/orangepi.c
hw/arm/raspi.c
hw/arm/realview.c
hw/arm/sabrelite.c
hw/misc/sifive_u_otp.c
hw/riscv/microchip_pfsoc.c
hw/riscv/sifive_u.c
hw/sparc64/niagara.c