]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
firewire: sbp2: Fix SCSI sense data mangling
authorChris Boot <bootc@bootc.net>
Wed, 15 Feb 2012 14:59:10 +0000 (14:59 +0000)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Wed, 22 Feb 2012 21:36:02 +0000 (22:36 +0100)
commit6503de65459da619d3ade0824c9cc17ea0a57141
tree4d2212199dfa1b72239594479345cb2a9c5c73af
parent74044563a2318f2c56fa53af64f7800f49fb479d
firewire: sbp2: Fix SCSI sense data mangling

SCSI sense data in SBP-2/3 is carried in an unusual format that means we
have to un-mangle it on our end before we pass it to the SCSI subsystem.
Currently our un-mangling code doesn't quite follow the SBP-2 standard
in that we always assume Current and never Deferred error types, we
never set the VALID bit, and we mishandle the FILEMARK, EOM and ILI
bits.

This patch fixes the sense un-mangling to correctly handle those and
follow the spec.

Signed-off-by: Chris Boot <bootc@bootc.net>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/sbp2.c