]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
irqchip/ti-sci-inta: Fix processing of masked irqs
authorGrygorii Strashko <grygorii.strashko@ti.com>
Wed, 8 Apr 2020 19:15:32 +0000 (22:15 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 5 May 2020 10:32:22 +0000 (12:32 +0200)
commit65a70c89c3c79e9ef063d6242b13268bfb44303a
tree9efd58c3e89b32a1580827ad42a094670dd45855
parentb1985005bef78b64bc9acce7b886a99733412df7
irqchip/ti-sci-inta: Fix processing of masked irqs

BugLink: https://bugs.launchpad.net/bugs/1874111
commit 3688b0db5c331f4ec3fa5eb9f670a4b04f530700 upstream.

The ti_sci_inta_irq_handler() does not take into account INTA IRQs state
(masked/unmasked) as it uses INTA_STATUS_CLEAR_j register to get INTA IRQs
status, which provides raw status value.
This causes hard IRQ handlers to be called or threaded handlers to be
scheduled many times even if corresponding INTA IRQ is masked.
Above, first of all, affects the LEVEL interrupts processing and causes
unexpected behavior up the system stack or crash.

Fix it by using the Interrupt Masked Status INTA_STATUSM_j register which
provides masked INTA IRQs status.

Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Link: https://lore.kernel.org/r/20200408191532.31252-1-grygorii.strashko@ti.com
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/irqchip/irq-ti-sci-inta.c