]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
lib/xz: Validate the value before assigning it to an enum variable
authorLasse Collin <lasse.collin@tukaani.org>
Sun, 10 Oct 2021 21:31:40 +0000 (05:31 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Thu, 13 Jan 2022 17:42:11 +0000 (18:42 +0100)
commit65b84f1ee7e862ce36d10aa37f8de57a26c14fcd
treefaffa6ed391ea2004349ea227f7350dc9dae3377
parentaf27a9d068e86dd29056cef8876d8ed879c5fffa
lib/xz: Validate the value before assigning it to an enum variable

BugLink: https://bugs.launchpad.net/bugs/1953387
[ Upstream commit 4f8d7abaa413c34da9d751289849dbfb7c977d05 ]

This might matter, for example, if the underlying type of enum xz_check
was a signed char. In such a case the validation wouldn't have caught an
unsupported header. I don't know if this problem can occur in the kernel
on any arch but it's still good to fix it because some people might copy
the XZ code to their own projects from Linux instead of the upstream
XZ Embedded repository.

This change may increase the code size by a few bytes. An alternative
would have been to use an unsigned int instead of enum xz_check but
using an enumeration looks cleaner.

Link: https://lore.kernel.org/r/20211010213145.17462-3-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
lib/xz/xz_dec_stream.c