]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ravb: Disable Pause Advertisement
authorAndrew Lunn <andrew@lunn.ch>
Fri, 21 Sep 2018 13:52:26 +0000 (15:52 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 22 Sep 2018 02:26:52 +0000 (19:26 -0700)
commit65c5877f64623dcb603082e7b3533a25a2601f1b
tree0e1d681217169cf5dd5483856ca635fe8170f89d
parentb4d0782440ed38c14ff145ead241d5fcc95a37b7
ravb: Disable Pause Advertisement

The previous commit to ravb had the side effect of making the PHY
advertise Pause and Asym Pause, which previously did not happen.  By
default, phydev->supported has both forms of pause enabled, but
phydev->advertising does not. The new phy_remove_link_mode() copies
phydev->supported to phydev->advertising after removing the requested
link mode. These Pause configuration bits appears it stops the PHY
from completing Auto-Neg and the link remains down.  Be explicit and
remove the Pause and Asym Pause modes, so restoring the old behavior.

Fixes: 41124fa64d4b ("net: ethernet: Add helper to remove a supported link mode")
Reported-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/ravb_main.c