]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
hwrng: omap3-rom - Fix missing clock by probing with device tree
authorTony Lindgren <tony@atomide.com>
Sat, 14 Sep 2019 21:02:55 +0000 (14:02 -0700)
committerPaolo Pisati <paolo.pisati@canonical.com>
Thu, 30 Jan 2020 15:27:27 +0000 (16:27 +0100)
commit6621de8db5fd9519c6cf215e491bad7d83d3b691
tree412251c1549260c483d6796a43966e29acbde67f
parent50345809164e6aa033d5d64046ddc4eec5aed7cd
hwrng: omap3-rom - Fix missing clock by probing with device tree

BugLink: https://bugs.launchpad.net/bugs/1861091
[ Upstream commit 0c0ef9ea6f3f0d5979dc7b094b0a184c1a94716b ]

Commit 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
removed old omap3 clock framework aliases but caused omap3-rom-rng to
stop working with clock not found error.

Based on discussions on the mailing list it was requested by Tero Kristo
that it would be best to fix this issue by probing omap3-rom-rng using
device tree to provide a proper clk property. The other option would be
to add back the missing clock alias, but that does not help moving things
forward with removing old legacy platform_data.

Let's also add a proper device tree binding and keep it together with
the fix.

Cc: devicetree@vger.kernel.org
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Adam Ford <aford173@gmail.com>
Cc: Pali Rohár <pali.rohar@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Tero Kristo <t-kristo@ti.com>
Fixes: 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Documentation/devicetree/bindings/rng/omap3_rom_rng.txt [new file with mode: 0644]
arch/arm/boot/dts/omap3-n900.dts
arch/arm/mach-omap2/pdata-quirks.c
drivers/char/hw_random/omap3-rom-rng.c