]> git.proxmox.com Git - qemu.git/commit
cpu_physical_memory_write_rom() needs to do TB invalidates
authorDavid Gibson <david@gibson.dropbear.id.au>
Mon, 10 Sep 2012 02:30:57 +0000 (12:30 +1000)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 12 Oct 2012 02:44:19 +0000 (21:44 -0500)
commit668194d5a515247768d95f10fea933e27e3e3c95
treed6e51bb3e7f467ac798ed366b3b5d0a1700efda7
parent8484fead29c731a5902b1c183e64c179a13a15b8
cpu_physical_memory_write_rom() needs to do TB invalidates

cpu_physical_memory_write_rom(), despite the name, can also be used to
write images into RAM - and will often be used that way if the machine
uses load_image_targphys() into RAM addresses.

However, cpu_physical_memory_write_rom(), unlike cpu_physical_memory_rw()
doesn't invalidate any cached TBs which might be affected by the region
written.

This was breaking reset (under full emu) on the pseries machine - we loaded
our firmware image into RAM, and while executing it rewrite the code at
the entry point (correctly causing a TB invalidate/refresh).  When we
reset the firmware image was reloaded, but the TB from the rewrite was
still active and caused us to get an illegal instruction trap.

This patch fixes the bug by duplicating the tb invalidate code from
cpu_physical_memory_rw() in cpu_physical_memory_write_rom().

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
(cherry picked from commit 0b57e287138728f72d88b06e69b970c5d745c44a)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
exec.c