]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
printk: ringbuffer: fix line counting
authorJohn Ogness <john.ogness@linutronix.de>
Wed, 13 Jan 2021 14:42:34 +0000 (15:48 +0106)
committerPetr Mladek <pmladek@suse.com>
Fri, 15 Jan 2021 10:30:03 +0000 (11:30 +0100)
commit668af87f995b6d6d09595c088ad1fb5dd9ff25d2
tree45dd411f4de2f3e058c5349ea06ffccf3d121308
parentb031a684bfd01d633c79d281bd0cf11c2f834ada
printk: ringbuffer: fix line counting

Counting text lines in a record simply involves counting the number
of newline characters (+1). However, it is searching the full data
block for newline characters, even though the text data can be (and
often is) a subset of that area. Since the extra area in the data
block was never initialized, the result is that extra newlines may
be seen and counted.

Restrict newline searching to the text data length.

Fixes: b6cf8b3f3312 ("printk: add lockless ringbuffer")
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20210113144234.6545-1-john.ogness@linutronix.de
kernel/printk/printk_ringbuffer.c