]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
carl9170: Fix mismatch in carl9170_op_set_key mutex lock-unlock
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Tue, 23 Aug 2011 20:44:32 +0000 (00:44 +0400)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 24 Aug 2011 17:52:27 +0000 (13:52 -0400)
commit66cb54bd24086b2d871a03035de9b0e79b2b725e
tree0d8c6a8790026404bfb18e3bb00f78488a811db4
parent7a5e4877c14de0827dbda8efa5080089757a8733
carl9170: Fix mismatch in carl9170_op_set_key mutex lock-unlock

If is_main_vif(ar, vif) reports that we have to fall back
to software encryption, we goto err_softw; before locking ar->mutex.
As a result, we have unprotected call to carl9170_set_operating_mode
and unmatched mutex_unlock.

The patch fix the issue by adding mutex_lock before goto.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: <stable@kernel.org>
Acked-By: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/carl9170/main.c