]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
selftests: bonding: do not set port down before adding to bond
authorHangbin Liu <liuhangbin@gmail.com>
Thu, 17 Aug 2023 08:24:59 +0000 (16:24 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 30 Oct 2023 11:00:25 +0000 (12:00 +0100)
commit66f535be876b99a5ea4e869dc071e5f9a0d929e8
tree2a166889e8ef61a09deb8b6deb39f9995edd65aa
parent4a33b8d1dd04b9eb10b37a47466c59b1238099f9
selftests: bonding: do not set port down before adding to bond

BugLink: https://bugs.launchpad.net/bugs/2039742
[ Upstream commit be809424659c2844a2d7ab653aacca4898538023 ]

Before adding a port to bond, it need to be set down first. In the
lacpdu test the author set the port down specifically. But commit
a4abfa627c38 ("net: rtnetlink: Enslave device before bringing it up")
changed the operation order, the kernel will set the port down _after_
adding to bond. So all the ports will be down at last and the test failed.

In fact, the veth interfaces are already inactive when added. This
means there's no need to set them down again before adding to the bond.
Let's just remove the link down operation.

Fixes: a4abfa627c38 ("net: rtnetlink: Enslave device before bringing it up")
Reported-by: Zhengchao Shao <shaozhengchao@huawei.com>
Closes: https://lore.kernel.org/netdev/a0ef07c7-91b0-94bd-240d-944a330fcabd@huawei.com/
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://lore.kernel.org/r/20230817082459.1685972-1-liuhangbin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh