]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
btrfs: avoid start and commit empty transaction when starting qgroup rescan
authorFilipe Manana <fdmanana@suse.com>
Wed, 26 Jul 2023 15:57:12 +0000 (16:57 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 21 Aug 2023 12:52:18 +0000 (14:52 +0200)
commit6705b48a50d7cad55b763ae4c9544875a9727f80
treef438ab0236fa3c6f849b1cc86447e58f4757fdc5
parent2ee70ed19ccd9c95c188816b65dacf3fca1f5565
btrfs: avoid start and commit empty transaction when starting qgroup rescan

When starting a qgroup rescan, we try to join a running transaction, with
btrfs_join_transaction(), and then commit the transaction. However using
btrfs_join_transaction() will result in creating a new transaction in case
there isn't any running or if there's an existing one already committing.
This is pointless as we only need to attach to an existing one that is
not committing and in case there's an existing one committing, wait for
its commit to complete. Creating and committing an empty transaction is
wasteful, pointless IO and unnecessary rotation of the backup roots.

So use btrfs_attach_transaction_barrier() instead, to avoid creating and
committing empty transactions.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/qgroup.c