]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
blk-cgroup: Use cond_resched() when destroy blkgs
authorBaolin Wang <baolin.wang@linux.alibaba.com>
Thu, 28 Jan 2021 05:58:15 +0000 (13:58 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 24 Mar 2021 10:11:50 +0000 (11:11 +0100)
commit67e5448e7c779d6dde4d0972e68932b444aa9b0f
tree8a8c8e8bbcd165b97c27281daf9d8d868c153b5b
parentdd7094bca44b24d31f91f598b27ee056d6f1c325
blk-cgroup: Use cond_resched() when destroy blkgs

BugLink: https://bugs.launchpad.net/bugs/1918158
[ Upstream commit 6c635caef410aa757befbd8857c1eadde5cc22ed ]

On !PREEMPT kernel, we can get below softlockup when doing stress
testing with creating and destroying block cgroup repeatly. The
reason is it may take a long time to acquire the queue's lock in
the loop of blkcg_destroy_blkgs(), or the system can accumulate a
huge number of blkgs in pathological cases. We can add a need_resched()
check on each loop and release locks and do cond_resched() if true
to avoid this issue, since the blkcg_destroy_blkgs() is not called
from atomic contexts.

[ 4757.010308] watchdog: BUG: soft lockup - CPU#11 stuck for 94s!
[ 4757.010698] Call trace:
[ 4757.010700]  blkcg_destroy_blkgs+0x68/0x150
[ 4757.010701]  cgwb_release_workfn+0x104/0x158
[ 4757.010702]  process_one_work+0x1bc/0x3f0
[ 4757.010704]  worker_thread+0x164/0x468
[ 4757.010705]  kthread+0x108/0x138

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
block/blk-cgroup.c