]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
Use correct NET_RX_* returns for atalk_rcv()
authorMark Smith <lk-netdev@lk-netdev.nosense.org>
Thu, 6 Aug 2009 23:21:22 +0000 (23:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Aug 2009 03:44:50 +0000 (20:44 -0700)
commit6885ffb3a1b4abf731fd0891a2c1544a83c2651d
tree20d18c7787dca4100243b122d8485fbbb76215eb
parentb91cd1440870f7a0649e570498b7b93caf9f781c
Use correct NET_RX_* returns for atalk_rcv()

In all rx'd SKB cases, atalk_rcv() either eventually jumps to or falls through
    to the label out:, which  returns numeric 0. Numeric 0 corresponds to
    NET_RX_SUCCESS, which is incorrect in failed SKB cases.

    This patch makes atalk_rcv() provide the correct returns by:

    o  explicitly returning NET_RX_SUCCESS in the two success cases
    o  having the out: label return NET_RX_DROP, instead of numeric 0
    o  making the failed SKB labels and processing more consistent with other
       _rcv() routines in the kernel, simplifying validation and removing a
       backwards goto

Signed-off-by: Mark Smith <markzzzsmith@yahoo.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/appletalk/ddp.c