]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
ASoC: Intel: broadwell: Revert back SSP0 link to use dummy components
authorCezary Rojewski <cezary.rojewski@intel.com>
Wed, 25 Mar 2020 13:16:09 +0000 (14:16 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 25 Mar 2020 21:33:26 +0000 (21:33 +0000)
commit68999d939dcfb430dd9834df56c71e43b7f37c6e
treec3da18a63ffcdcd4c860bd4a2a890305337f0921
parenteedf8a126629bf9db8ad3a2a5dc9dc1798fb2302
ASoC: Intel: broadwell: Revert back SSP0 link to use dummy components

Recent series of patches targeting broadwell boards, while enabling
SOF, changed behavior for non-SOF solutions. In essence replacing
platform 'dummy' with actual 'platform' causes redundant stream
initialization to occur during audio start. hw_params for haswell-pcm
destroys initial stream right after its creation - only to recreate it
again from proceed from there.

While harmless so far, this flow isn't correct and should be corrected.
The actual need for dummy components for SSP0 link is questionable but
that issue is subject for another series.

Link to first message in conversation:
https://lkml.org/lkml/2020/3/18/54

Fixes: 64df6afa0dab ("ASoC: Intel: broadwell: change cpu_dai and platform components for SOF")
Reported-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200325131611.545-2-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/broadwell.c