]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
net: davinci_emac: fix oops caused by uninitialized ndev->dev
authorSekhar Nori <nsekhar@ti.com>
Tue, 20 May 2014 10:11:37 +0000 (15:41 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 May 2014 19:22:36 +0000 (15:22 -0400)
commit68bc74feb0ce1cc79cb2b5bbdfc592f30f37dab8
treec1a912d8f20ae13b1d5a28283561f4dd63d9b299
parentcb421c2845dfb496637dd00c6780682bb3b1e3c5
net: davinci_emac: fix oops caused by uninitialized ndev->dev

Commit e194312854edc22a2faf1931b3c0608fe20cb969 (drivers: net:
davinci_cpdma: Convert kzalloc() to devm_kzalloc()) triggered
a bug in emac_probe() wherein dev member of net_device is used
for devres allocations even before it is initialized.

This patch fixes that by using the struct device in platform_device
instead.

While at it, use &pdev->dev consistently for console messages instead
of using ndev->dev for just one case and remove an unnecessary line
continuation.

Reported-by: Kevin Hilman <khilman@linaro.org>
Helped-by: George Cherian <george.cherian@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Tested-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Tested-by: Kevin Hilman <khilman@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/davinci_emac.c