]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
USB: Revert "cdc-wdm: fix "out-of-sync" due to missing notifications"
authorBjørn Mork <bjorn@mork.no>
Fri, 21 Apr 2017 08:01:29 +0000 (10:01 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 20 Jun 2017 08:50:12 +0000 (10:50 +0200)
commit68ffaa85a328c5e514da3da19d58bfa518c2f67f
treed661c56feae3175ba1bd40aa123a9db2fc926203
parent2296b779cb1ee88aac788b8970db870d85aa40f9
USB: Revert "cdc-wdm: fix "out-of-sync" due to missing notifications"

BugLink: http://bugs.launchpad.net/bugs/1692898
commit 19445816996d1a89682c37685fe95959631d9f32 upstream.

This reverts commit 833415a3e781 ("cdc-wdm: fix "out-of-sync" due to
missing notifications")

There have been several reports of wdm_read returning unexpected EIO
errors with QMI devices using the qmi_wwan driver. The reporters
confirm that reverting prevents these errors. I have been unable to
reproduce the bug myself, and have no explanation to offer either. But
reverting is the safe choice here, given that the commit was an
attempt to work around a firmware problem.  Living with a firmware
problem is still better than adding driver bugs.

Reported-by: Kasper Holtze <kasper@holtze.dk>
Reported-by: Aleksander Morgado <aleksander@aleksander.es>
Reported-by: Daniele Palmas <dnlplm@gmail.com>
Fixes: 833415a3e781 ("cdc-wdm: fix "out-of-sync" due to missing notifications")
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Acked-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/class/cdc-wdm.c