]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
gpio: wcd934x: Fix shift-out-of-bounds error
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Tue, 25 May 2021 16:55:39 +0000 (17:55 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Thu, 15 Jul 2021 17:24:12 +0000 (19:24 +0200)
commit69261c36877c6a70daa9a84362f508a36eb68cc6
tree698027a4d081539cf21dcc25714a62fbce2eb752
parent5b1ea1e84d04d714e6f4b67c3c810b2bba314868
gpio: wcd934x: Fix shift-out-of-bounds error

BugLink: https://bugs.launchpad.net/bugs/1934012
commit dbec64b11c65d74f31427e2b9d5746fbf17bf840 upstream.

bit-mask for pins 0 to 4 is BIT(0) to BIT(4) however we ended up with BIT(n - 1)
which is not right, and this was caught by below usban check

UBSAN: shift-out-of-bounds in drivers/gpio/gpio-wcd934x.c:34:14

Fixes: 59c324683400 ("gpio: wcd934x: Add support to wcd934x gpio controller")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/gpio/gpio-wcd934x.c