]> git.proxmox.com Git - mirror_qemu.git/commit
qdev: Fix object reference leak in case device.realize() fails
authorIgor Mammedov <imammedo@redhat.com>
Mon, 25 Jul 2016 09:59:22 +0000 (11:59 +0200)
committerEduardo Habkost <ehabkost@redhat.com>
Tue, 26 Jul 2016 18:32:04 +0000 (15:32 -0300)
commit69382d8b3e8600b349c191394d761dcb480502cf
treed996c397ca0aede09fe68c8bbf7a4b26e28ed369
parenta07f953ef4ef48058c24fb50b49e6fa28bf5f5f4
qdev: Fix object reference leak in case device.realize() fails

If device doesn't have parent assined before its realize
is called, device_set_realized() will implicitly set parent
to '/machine/unattached'.

However device_set_realized() may fail after that point at
several other points leaving not realized object dangling
in '/machine/unattached' and as result caller of

  obj = object_new()
    obj->ref == 1
  object_property_set_bool(obj,..., true, "realized",...)
    obj->ref == 2
  if (fail)
      object_unref(obj);
      obj->ref == 1

will get object leak instead of expected object destruction.

Fix it by making device_set_realized() to cleanup after itself
in case of failure.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
hw/core/qdev.c