]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
ACPI / DMAR: Avoid passing NULL to acpi_put_table()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 5 Jan 2017 01:13:31 +0000 (02:13 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 5 Jan 2017 14:10:52 +0000 (15:10 +0100)
commit696c7f8e0373026e8bfb29b2d9ff2d0a92059d4d
treeb933c78b92d1887fdb28dc7be93af426053da036
parent0c744ea4f77d72b3dcebb7a8f2684633ec79be88
ACPI / DMAR: Avoid passing NULL to acpi_put_table()

Linus reported that commit 174cc7187e6f "ACPICA: Tables: Back port
acpi_get_table_with_size() and early_acpi_os_unmap_memory() from
Linux kernel" added a new warning on his desktop system:

 ACPI Warning: Table ffffffff9fe6c0a0, Validation count is zero before decrement

which turns out to come from the acpi_put_table() in
detect_intel_iommu().

This happens if the DMAR table is not present in which case NULL is
passed to acpi_put_table() which doesn't check against that and
attempts to handle it regardless.

For this reason, check the pointer passed to acpi_put_table()
before invoking it.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Tested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Fixes: 6b11d1d67713 ("ACPI / osl: Remove acpi_get_table_with_size()/early_acpi_os_unmap_memory() users")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/iommu/dmar.c