]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net: use skb_to_full_sk() in skb_update_prio()
authorEric Dumazet <edumazet@google.com>
Wed, 14 Mar 2018 16:04:16 +0000 (09:04 -0700)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Mon, 2 Apr 2018 10:19:49 +0000 (07:19 -0300)
commit699cb7c6c4c08d862844ebddf7641c4cb993ffd0
tree7628cbe2d51f07ed29ac5876df172e80e1acd580
parentfc9f895287455d1e739f8080798bf78e8009d3bf
net: use skb_to_full_sk() in skb_update_prio()

BugLink: http://bugs.launchpad.net/bugs/1760585
[ Upstream commit 4dcb31d4649df36297296b819437709f5407059c ]

Andrei Vagin reported a KASAN: slab-out-of-bounds error in
skb_update_prio()

Since SYNACK might be attached to a request socket, we need to
get back to the listener socket.
Since this listener is manipulated without locks, add const
qualifiers to sock_cgroup_prioidx() so that the const can also
be used in skb_update_prio()

Also add the const qualifier to sock_cgroup_classid() for consistency.

Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Andrei Vagin <avagin@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
include/linux/cgroup-defs.h
net/core/dev.c