]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
fbdev: omapfb/sharp-ls037v7dw01: Don't put .remove() in .exit.text and drop suppress_...
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 7 Nov 2023 09:17:50 +0000 (10:17 +0100)
committerHelge Deller <deller@gmx.de>
Fri, 10 Nov 2023 06:34:18 +0000 (07:34 +0100)
commit6a06fc772fa53a436e50aef44f4163253dbb089f
tree0ab93dbd467dd5c14c15e5d54b2afa90697f43e6
parent7462e46054c5ce07639aabec5b605d6a481368b1
fbdev: omapfb/sharp-ls037v7dw01: Don't put .remove() in .exit.text and drop suppress_bind_attrs

On today's platforms the memory savings of putting the remove function
in .exit isn't that relevant any more. It only matters for built-in
drivers and typically saves a few 100k.

The downside is that the driver cannot be unbound at runtime which is
ancient and also slightly complicates testing. Also it requires to mark
the driver struct with __refdata which is needed to suppress a (W=1)
modpost warning:

WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01: section mismatch in reference: sharp_ls_driver+0x4 (section: .data) -> sharp_ls_remove (section: .exit.text)

To simplify matters, move the remove callback to .text and drop
.suppress_bind_attrs = true.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c