]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drivers/atm: Use DIV_ROUND_UP
authorJulia Lawall <julia@diku.dk>
Tue, 23 Sep 2008 02:22:58 +0000 (19:22 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Sep 2008 02:22:58 +0000 (19:22 -0700)
commit6a19309db0a02d821494f4df754046c85a230627
tree03936c1806097bb4e0aafc9956e866727f713ea9
parentca330c5a913a9b1690c709f4cfcd6be0c8696b14
drivers/atm: Use DIV_ROUND_UP

The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /
(d)) but is perhaps more readable.

In the case of the file drivers/atm/eni.c, I am a little bit suspicious of
the -1 at the end of the affected expression.  Please check that that is
what is wanted.

An extract of the semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@haskernel@
@@

#include <linux/kernel.h>

@depends on haskernel@
expression n,d;
@@

(
- (n + d - 1) / d
+ DIV_ROUND_UP(n,d)
|
- (n + (d - 1)) / d
+ DIV_ROUND_UP(n,d)
)

@depends on haskernel@
expression n,d;
@@

- DIV_ROUND_UP((n),d)
+ DIV_ROUND_UP(n,d)

@depends on haskernel@
expression n,d;
@@

- DIV_ROUND_UP(n,(d))
+ DIV_ROUND_UP(n,d)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/eni.c
drivers/atm/horizon.c
drivers/atm/zatm.c