]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
NET: wan/x25, fix ldisc->open retval
authorJiri Slaby <jslaby@suse.cz>
Wed, 24 Nov 2010 23:27:55 +0000 (00:27 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 29 Nov 2010 22:51:54 +0000 (14:51 -0800)
commit6a20bd45fda271bd57e3ba41b3de3009797f4b5e
treed0699ec589106045e082b8fd7035860b616d1cbd
parent7f90cfc505d613f4faf096e0d84ffe99208057d9
NET: wan/x25, fix ldisc->open retval

We should never return positive values from ldisc->open, tty layer
doesn't (and never did) expect that.

If we do that, weird things like warnings in tty_ldisc_close happen.

Not sure if dev->base_addr is used somehow now.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Andrew Hendry <andrew.hendry@gmail.com>
Cc: linux-x25@vger.kernel.org
Tested-by: Sergey Lapin <slapin@ossfans.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wan/x25_asy.c