]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net/mlx5e: Lower maximum allowed MTU in XSK to match XDP prerequisites
authorAdham Faris <afaris@nvidia.com>
Mon, 23 Jan 2023 08:09:01 +0000 (10:09 +0200)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Wed, 17 May 2023 11:33:45 +0000 (13:33 +0200)
commit6a4edf0e401d07d64525338729a37076d798a737
treebf0361743b6869bc4c4bfb37f283b621b9d3d733
parent214efc81a068d0272a60d02dcb7c9311871600a5
net/mlx5e: Lower maximum allowed MTU in XSK to match XDP prerequisites

BugLink: https://bugs.launchpad.net/bugs/2016878
[ Upstream commit 78dee7befd56987283c13877b834c0aa97ad51b9 ]

XSK redirecting XDP programs require linearity, hence applies
restrictions on the MTU. For PAGE_SIZE=4K, MTU shouldn't exceed 3498.

Features that contradict with XDP such HW-LRO and HW-GRO are enforced
by the driver in advance, during XSK params validation, except for MTU,
which was not enforced before this patch.

This has been spotted during test scenario described below:
Attaching xdpsock program (PAGE_SIZE=4K), with MTU < 3498, detaching
XDP program, changing the MTU to arbitrary value in the range
[3499, 3754], attaching XDP program again, which ended up with failure
since MTU is > 3498.

This commit lowers the XSK MTU limitation to be aligned with XDP MTU
limitation, since XSK socket is meaningless without XDP program.

Signed-off-by: Adham Faris <afaris@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c