]> git.proxmox.com Git - mirror_qemu.git/commit
qmp-test: Drop dependence on global_qtest
authorEric Blake <eblake@redhat.com>
Mon, 11 Sep 2017 17:20:06 +0000 (12:20 -0500)
committerThomas Huth <thuth@redhat.com>
Wed, 14 Feb 2018 10:43:41 +0000 (11:43 +0100)
commit6a5c88f5728d33994b828ad4a333752269f08d92
treebdaaf16b36d7ef62930a6d1fb6d7807724a802b6
parent3d95fb9770f0fbf4396879bb6152b0e78edf0546
qmp-test: Drop dependence on global_qtest

As a general rule, we prefer avoiding implicit global state
because it makes code harder to safely copy and paste without
thinking about the global state.  Although qmp-test does not
maintain parallel qtest connections, it was the last test
assigning to global_qtest.  It's just as easy to be explicit
about the state; once all tests have been cleaned up, a later
patch can then get rid of global_qtest and a layer of wrappers
in libqtest.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/qmp-test.c