]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
crypto: arm,arm64 - Fix random regeneration of S_shipped
authorLeonard Crestez <leonard.crestez@nxp.com>
Tue, 13 Mar 2018 20:17:23 +0000 (22:17 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 23 Mar 2018 15:43:19 +0000 (23:43 +0800)
commit6aaf49b495b446ff6eec0ac983f781ca0dc56a73
tree6702ab8edb6881406d6fae1cdfb36f88d3e5600a
parenteb428ee0e3ca6c8ea6fdfdf24a5918f739933119
crypto: arm,arm64 - Fix random regeneration of S_shipped

The decision to rebuild .S_shipped is made based on the relative
timestamps of .S_shipped and .pl files but git makes this essentially
random. This means that the perl script might run anyway (usually at
most once per checkout), defeating the whole purpose of _shipped.

Fix by skipping the rule unless explicit make variables are provided:
REGENERATE_ARM_CRYPTO or REGENERATE_ARM64_CRYPTO.

This can produce nasty occasional build failures downstream, for example
for toolchains with broken perl. The solution is minimally intrusive to
make it easier to push into stable.

Another report on a similar issue here: https://lkml.org/lkml/2018/3/8/1379

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/arm/crypto/Makefile
arch/arm64/crypto/Makefile