]> git.proxmox.com Git - mirror_qemu.git/commit
target/arm: Fix VNCR fault detection logic
authorPeter Maydell <peter.maydell@linaro.org>
Tue, 16 Jan 2024 16:56:05 +0000 (16:56 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 26 Jan 2024 11:30:47 +0000 (11:30 +0000)
commit6b504a01c17de92f2851d63f181210eff97191d0
treee261956c8c798f6763c30a35d2a3eefa2e22dce2
parent604927e357c2b292c70826e4ce42574ad126ef32
target/arm: Fix VNCR fault detection logic

In arm_deliver_fault() we check for whether the fault is caused
by a data abort due to an access to a FEAT_NV2 sysreg in the
memory pointed to by the VNCR. Unfortunately part of the
condition checks the wrong argument to the function, meaning
that it would spuriously trigger, resulting in some instruction
aborts being taken to the wrong EL and reported incorrectly.

Use the right variable in the condition.

Fixes: 674e5345275d425 ("target/arm: Report VNCR_EL2 based faults correctly")
Reported-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-id: 20240116165605.2523055-1-peter.maydell@linaro.org
target/arm/tcg/tlb_helper.c