]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 6 Apr 2019 05:26:52 +0000 (08:26 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 30 Jul 2019 10:58:17 +0000 (12:58 +0200)
commit6b8817f849a512b6de152ff539146682daef929a
treed8947f00548acca84f1e4c881fa5faa7bb3cbd86
parent6226a5fa012e976663c1dae8051367978b691f88
netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()

BugLink: https://bugs.launchpad.net/bugs/1836577
[ Upstream commit 33d1c018179d0a30c39cc5f1682b77867282694b ]

I believe that "hook->num" can be up to UINT_MAX.  Shifting more than
31 bits would is undefined in C but in practice it would lead to shift
wrapping.  That would lead to an array overflow in nf_tables_addchain():

ops->hook       = hook.type->hooks[ops->hooknum];

Fixes: fe19c04ca137 ("netfilter: nf_tables: remove nhooks field from struct nft_af_info")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
net/netfilter/nf_tables_api.c