]> git.proxmox.com Git - mirror_qemu.git/commit
projects / mirror_qemu.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 93abfc8) | patch
ramfb: fix overflow
authorGerd Hoffmann <kraxel@redhat.com>
Tue, 26 Jun 2018 08:31:19 +0000 (10:31 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Tue, 26 Jun 2018 14:04:01 +0000 (16:04 +0200)
commit6b9b3c1e303cc0dda99e326031d2b1b612b80e3b
treecb668a3a00718eb8cccecd5905ce3ff3bffbc726tree
parent93abfc88bd649de1933588bfc7175605331b3ea9commit | diff
ramfb: fix overflow

> CID 1393621:    (OVERFLOW_BEFORE_WIDEN)
> Potentially overflowing expression "stride * s->height" with type "unsigned
> int" (32 bits, unsigned) is evaluated using +32-bit arithmetic, and then used
> in a context that expects an expression of type "hwaddr" (64 bits, unsigned).

Fix by changing stride from uint32_t to hwaddr.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20180626083120.19515-1-kraxel@redhat.com
hw/display/ramfb.c diff | blob | blame | history
QEMU mirror