]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
crypto: arm64/sha2-ce - correct digest for empty data in finup
authorElena Petrova <lenaptr@google.com>
Tue, 28 May 2019 14:35:06 +0000 (15:35 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 6 Jun 2019 06:38:57 +0000 (14:38 +0800)
commit6bd934de1e393466b319d29c4427598fda096c57
treea3d7344c872a7bc71ea1ef9dd4e7a4b1e5682c8a
parent1d4aaf16defa86d2665ae7db0259d6cb07e2091f
crypto: arm64/sha2-ce - correct digest for empty data in finup

The sha256-ce finup implementation for ARM64 produces wrong digest
for empty input (len=0). Expected: the actual digest, result: initial
value of SHA internal state. The error is in sha256_ce_finup:
for empty data `finalize` will be 1, so the code is relying on
sha2_ce_transform to make the final round. However, in
sha256_base_do_update, the block function will not be called when
len == 0.

Fix it by setting finalize to 0 if data is empty.

Fixes: 03802f6a80b3a ("crypto: arm64/sha2-ce - move SHA-224/256 ARMv8 implementation to base layer")
Cc: stable@vger.kernel.org
Signed-off-by: Elena Petrova <lenaptr@google.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/arm64/crypto/sha2-ce-glue.c