]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: dsa: bcm_sf2: Fix IPv6 rules and chain ID
authorFlorian Fainelli <f.fainelli@gmail.com>
Tue, 15 May 2018 23:01:24 +0000 (16:01 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 May 2018 18:11:22 +0000 (14:11 -0400)
commit6c05561c541843b2bec2189f680bed6d20afc25b
tree894df56cec85e31331ae9d327571f0756f804eb6
parent43a5e00f38fe8933a1c716bfe5b30e97f749d94b
net: dsa: bcm_sf2: Fix IPv6 rules and chain ID

We had several issues that would make the programming of IPv6 rules both
inconsistent and error prone:

- the chain ID that we would be asking the hardware to put in the
  packet's Broadcom tag would be off by one, it would return one of the
  two indexes, but not the one user-space specified

- when an user specified a particular location to insert a CFP rule at,
  we would not be returning the same index, which would be confusing if
  nothing else

- finally, like IPv4, it would be possible to overflow the last entry by
  re-programming it

Fix this by swapping the usage of rule_index[0] and rule_index[1] where
relevant in order to return a consistent and correct user-space
experience.

Fixes: ba0696c22e7c ("net: dsa: bcm_sf2: Add support for IPv6 CFP rules")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/bcm_sf2_cfp.c