]> git.proxmox.com Git - mirror_qemu.git/commit
hw/xen/xen_pt_graphics: Don't trust the BIOS ROM contents so much
authorPeter Maydell <peter.maydell@linaro.org>
Mon, 19 Nov 2018 16:26:58 +0000 (16:26 +0000)
committerAnthony PERARD <anthony.perard@citrix.com>
Mon, 14 Jan 2019 13:45:40 +0000 (13:45 +0000)
commit6c4f984463a269e4d4f3684de957e3c548af409a
tree3376c10b3a241a3a58b1fc640c5f698ec157782f
parent7260438b7056469610ee166f7abe9ff8a26b8b16
hw/xen/xen_pt_graphics: Don't trust the BIOS ROM contents so much

Coverity (CID 796599) points out that xen_pt_setup_vga() trusts
the rom->size field in the BIOS ROM from a PCI passthrough VGA
device, and uses it as an index into the memory which contains
the BIOS image. A corrupt BIOS ROM could therefore cause us to
index off the end of the buffer.

Check that the size is within bounds before we use it.

We are also trusting the pcioffset field, and assuming that
the whole rom_header is present; Coverity doesn't notice these,
but check them too.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
hw/xen/xen_pt_graphics.c