]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
tipc: Fix tipc_sk_reinit handling of -EAGAIN
authorBob Peterson <rpeterso@redhat.com>
Wed, 23 Aug 2017 14:43:02 +0000 (10:43 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 Aug 2017 21:02:26 +0000 (14:02 -0700)
commit6c7e983b220f89e03286dc70a41c7ef3a8b409df
tree1ebaac5eee32fab5d7360c852260e500150b6ab9
parente58f95831e7468d25eb6e41f234842ecfe6f014f
tipc: Fix tipc_sk_reinit handling of -EAGAIN

In 9dbbfb0ab6680c6a85609041011484e6658e7d3c function tipc_sk_reinit
had additional logic added to loop in the event that function
rhashtable_walk_next() returned -EAGAIN. No worries.

However, if rhashtable_walk_start returns -EAGAIN, it does "continue",
and therefore skips the call to rhashtable_walk_stop(). That has
the effect of calling rcu_read_lock() without its paired call to
rcu_read_unlock(). Since rcu_read_lock() may be nested, the problem
may not be apparent for a while, especially since resize events may
be rare. But the comments to rhashtable_walk_start() state:

 * ...Note that we take the RCU lock in all
 * cases including when we return an error.  So you must always call
 * rhashtable_walk_stop to clean up.

This patch replaces the continue with a goto and label to ensure a
matching call to rhashtable_walk_stop().

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/socket.c