]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
fsi: scom: Remove retries in indirect scoms
authorJoel Stanley <joel@jms.id.au>
Tue, 7 Dec 2021 03:38:11 +0000 (14:08 +1030)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 27 Apr 2022 09:58:02 +0000 (11:58 +0200)
commit6c8aaae44345c7107a1fb90f937f7354e0b3b188
treec0f007b40a9fc9f79bc885277c27addd408c6c62
parentaced52be279dfb0336163df685c95665f6ac6da5
fsi: scom: Remove retries in indirect scoms

BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit ab1b79159ad5a6dc4e4994b49737f7feb13b7155 ]

In commit f72ddbe1d7b7 ("fsi: scom: Remove retries") the retries were
removed from get and put scoms. That patch missed the retires in get and
put indirect scom.

For the same reason, remove them from the scom driver to allow the
caller to decide to retry.

This removes the following special case which would have caused the
retry code to return early:

 -       if ((ind_data & XSCOM_DATA_IND_COMPLETE) || (err != SCOM_PIB_BLOCKED))
 -               return 0;

I believe this case is handled.

Fixes: f72ddbe1d7b7 ("fsi: scom: Remove retries")
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Eddie James <eajames@linux.ibm.com>
Link: https://lore.kernel.org/r/20211207033811.518981-3-joel@jms.id.au
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 28a886a308ed5221557bcc8d812e0cf0228501a8)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/fsi/fsi-scom.c