]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
block/scsi-ioctl: Fix kernel-infoleak in scsi_put_cdrom_generic_arg()
authorPeilin Ye <yepeilin.cs@gmail.com>
Fri, 2 Oct 2020 14:22:23 +0000 (10:22 -0400)
committerJens Axboe <axboe@kernel.dk>
Fri, 2 Oct 2020 18:01:47 +0000 (12:01 -0600)
commit6d53a9fe5a1983490bc14b3a64d49fabb4ccc651
tree696e521a32bfb23aa574e8aec1c27394e200a631
parent632bfb6323799c087fcb4108dfe59518609667a7
block/scsi-ioctl: Fix kernel-infoleak in scsi_put_cdrom_generic_arg()

scsi_put_cdrom_generic_arg() is copying uninitialized stack memory to
userspace, since the compiler may leave a 3-byte hole in the middle of
`cgc32`. Fix it by adding a padding field to `struct
compat_cdrom_generic_command`.

Cc: stable@vger.kernel.org
Fixes: f3ee6e63a9df ("compat_ioctl: move CDROM_SEND_PACKET handling into scsi")
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Reported-by: syzbot+85433a479a646a064ab3@syzkaller.appspotmail.com
Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/scsi_ioctl.c