]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
flow_offload: use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 23 May 2019 22:56:53 +0000 (17:56 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sat, 25 May 2019 17:57:58 +0000 (10:57 -0700)
commit6dca9360a9d7a15cef215cea4a55575dbfd2ebdd
tree5ac4753ef4b0c9e53e9288c57a0c7b0af6c58081
parent22942498ccebf13b076859f8746be161dc0c6d89
flow_offload: use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
   int stuff;
   struct boo entry[];
};

instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/flow_offload.c