]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
static_call: Allow module use without exposing static_call_key
authorJosh Poimboeuf <jpoimboe@redhat.com>
Wed, 27 Jan 2021 23:18:37 +0000 (17:18 -0600)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 8 Apr 2021 20:42:27 +0000 (15:42 -0500)
commit6e2f698e26d92bbc2d8fd8ebe58a90b0ae499dc5
tree4a004f71d921a33c3de4808129f34a4753964f8b
parentf8a1ecfa2f76b4000cf4482c0dd6954fcf29e3cd
static_call: Allow module use without exposing static_call_key

BugLink: https://bugs.launchpad.net/bugs/1922601
[ Upstream commit 73f44fe19d359635a607e8e8daa0da4001c1cfc2 ]

When exporting static_call_key; with EXPORT_STATIC_CALL*(), the module
can use static_call_update() to change the function called.  This is
not desirable in general.

Not exporting static_call_key however also disallows usage of
static_call(), since objtool needs the key to construct the
static_call_site.

Solve this by allowing objtool to create the static_call_site using
the trampoline address when it builds a module and cannot find the
static_call_key symbol. The module loader will then try and map the
trampole back to a key before it constructs the normal sites list.

Doing this requires a trampoline -> key associsation, so add another
magic section that keeps those.

Originally-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lkml.kernel.org/r/20210127231837.ifddpn7rhwdaepiu@treble
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
arch/x86/include/asm/static_call.h
include/asm-generic/vmlinux.lds.h
include/linux/static_call.h
include/linux/static_call_types.h
kernel/static_call.c
tools/include/linux/static_call_types.h
tools/objtool/check.c