]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
x86: uaccess: Inhibit speculation past access_ok() in user_access_begin()
authorWill Deacon <will.deacon@arm.com>
Sat, 19 Jan 2019 21:56:05 +0000 (21:56 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 20 Jan 2019 03:33:22 +0000 (15:33 +1200)
commit6e693b3ffecb0b478c7050b44a4842854154f715
tree3e46191be19e74dc996c422c03b22aa7818c0870
parentb0f3e768a89bbc72195023c3db1db45c40e5b70c
x86: uaccess: Inhibit speculation past access_ok() in user_access_begin()

Commit 594cc251fdd0 ("make 'user_access_begin()' do 'access_ok()'")
makes the access_ok() check part of the user_access_begin() preceding a
series of 'unsafe' accesses.  This has the desirable effect of ensuring
that all 'unsafe' accesses have been range-checked, without having to
pick through all of the callsites to verify whether the appropriate
checking has been made.

However, the consolidated range check does not inhibit speculation, so
it is still up to the caller to ensure that they are not susceptible to
any speculative side-channel attacks for user addresses that ultimately
fail the access_ok() check.

This is an oversight, so use __uaccess_begin_nospec() to ensure that
speculation is inhibited until the access_ok() check has passed.

Reported-by: Julien Thierry <julien.thierry@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/x86/include/asm/uaccess.h