]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
nfsd4: fix up replay_matches_cache()
authorScott Mayhew <smayhew@redhat.com>
Wed, 9 Oct 2019 19:11:37 +0000 (15:11 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 9 Oct 2019 20:39:31 +0000 (16:39 -0400)
commit6e73e92b155c868ff7fce9d108839668caf1d9be
tree9897fb3e0543c340c2ab4012174875d562f34762
parent832b2cb955437dcfe9b8f08e5f37303c9097fc87
nfsd4: fix up replay_matches_cache()

When running an nfs stress test, I see quite a few cached replies that
don't match up with the actual request.  The first comment in
replay_matches_cache() makes sense, but the code doesn't seem to
match... fix it.

This isn't exactly a bugfix, as the server isn't required to catch every
case of a false retry.  So, we may as well do this, but if this is
fixing a problem then that suggests there's a client bug.

Fixes: 53da6a53e1d4 ("nfsd4: catch some false session retries")
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c